Skip to content

feat(EVM-1167): cleanup storage types module#543

Open
0xVolosnikov wants to merge 5 commits intodevfrom
vv-evm-1167-storage-types-cleanup
Open

feat(EVM-1167): cleanup storage types module#543
0xVolosnikov wants to merge 5 commits intodevfrom
vv-evm-1167-storage-types-cleanup

Conversation

@0xVolosnikov
Copy link
Contributor

@0xVolosnikov 0xVolosnikov commented Feb 27, 2026 •
edited
Loading

What ❔

  • Removed unused storage-type markers/bitflags.
  • Split storage_types into focused modules.
  • Moved MAX_EVENT_TOPICS from storage types into system constants and updated imports.

Why ❔

  • Reduces dead code and improves module structure.
  • Places constants with the correct domain ownership for easier maintenance.

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

@0xVolosnikov 0xVolosnikov changed the title EVM-1167: cleanup storage types module feat(EVM-1167): cleanup storage types module Feb 27, 2026
@0xVolosnikov 0xVolosnikov marked this pull request as draft February 27, 2026 22:44
@0xVolosnikov 0xVolosnikov marked this pull request as ready for review February 27, 2026 22:59
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Benchmark report

Benchmark Symbol Base Eff Head Eff (%) Base Raw Head Raw (%) Base Blake Head Blake (%) Base Bigint Head Bigint (%)
block_19299001 process_block 315,681,952 315,681,952 (+0.00%) 273,016,552 273,016,552 (+0.00%) 410,630 410,630 (+0.00%) 9,023,830 9,023,830 (+0.00%)
block_22244135 process_block 197,585,908 197,585,908 (+0.00%) 170,670,116 170,670,116 (+0.00%) 172,040 172,040 (+0.00%) 6,040,788 6,040,788 (+0.00%)
precompiles bn254_ecadd 53,268 53,268 (+0.00%) 47,816 47,816 (+0.00%) 0 0 (+0.00%) 1,363 1,363 (+0.00%)
precompiles bn254_ecmul 728,781 728,781 (+0.00%) 564,593 564,593 (+0.00%) 0 0 (+0.00%) 41,047 41,047 (+0.00%)
precompiles bn254_pairing 72,336,733 72,336,733 (+0.00%) 57,808,589 57,808,589 (+0.00%) 0 0 (+0.00%) 3,632,036 3,632,036 (+0.00%)
precompiles ecrecover 479,193 477,504 (-0.35%) 310,609 309,652 (-0.31%) 0 0 (+0.00%) 42,146 41,963 (-0.43%)
precompiles id 927 927 (+0.00%) 927 927 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles keccak 137,579 137,579 (+0.00%) 137,579 137,579 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles modexp 31,267,857 31,267,857 (+0.00%) 20,610,037 20,610,037 (+0.00%) 0 0 (+0.00%) 2,664,455 2,664,455 (+0.00%)
precompiles p256_verify 748,861 748,861 (+0.00%) 470,169 470,169 (+0.00%) 0 0 (+0.00%) 69,673 69,673 (+0.00%)
precompiles point_evaluation 52,918,413 52,918,413 (+0.00%) 40,570,377 40,570,377 (+0.00%) 0 0 (+0.00%) 3,087,009 3,087,009 (+0.00%)
precompiles process_block 147,547,399 147,552,235 (+0.00%) 118,067,171 118,070,699 (+0.00%) 5,160 5,160 (+0.00%) 7,349,417 7,349,744 (+0.00%)
precompiles process_transaction 73,483,584 73,487,329 (+0.01%) 58,788,956 58,785,057 (-0.01%) 160 160 (+0.00%) 3,673,017 3,674,928 (+0.05%)
precompiles ripemd 8,013 8,013 (+0.00%) 8,013 8,013 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles run_tx_loop 146,895,882 146,900,504 (+0.00%) 117,495,334 117,498,648 (+0.00%) 180 180 (+0.00%) 7,349,417 7,349,744 (+0.00%)
precompiles sha256 13,168 13,168 (+0.00%) 13,168 13,168 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles system_init 46,785 46,785 (+0.00%) 46,785 46,785 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles verify_and_apply_batch 146,831 146,480 (-0.24%) 110,511 110,160 (-0.32%) 2,270 2,270 (+0.00%) 0 0 (+0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@0xVolosnikov